Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header + caching to runtime type generation #6329

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jul 24, 2024

What this PR solves / how to test

Fixes #6575

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal optimisation

@penalosa penalosa requested a review from a team as a code owner July 24, 2024 16:09
Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 3b31bd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Jul 24, 2024
Copy link
Contributor

github-actions bot commented Jul 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-wrangler-6329

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6329/npm-package-wrangler-6329

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-wrangler-6329 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-create-cloudflare-6329 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-cloudflare-kv-asset-handler-6329
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-miniflare-6329
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-cloudflare-pages-shared-6329
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-cloudflare-vitest-pool-workers-6329
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-cloudflare-workers-editor-shared-6329
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10885016555/npm-package-cloudflare-workers-shared-6329

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.1
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

Converting to draft because this feels like it is not yet ready for review.

@penalosa penalosa force-pushed the penalosa/type-file-header branch from f3d6711 to 8d931ac Compare August 27, 2024 21:51
@penalosa penalosa marked this pull request as ready for review August 27, 2024 21:53
Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One very minor comment.

packages/wrangler/src/type-generation/runtime/index.ts Outdated Show resolved Hide resolved
@penalosa penalosa merged commit c135de4 into main Sep 16, 2024
27 of 32 checks passed
@penalosa penalosa deleted the penalosa/type-file-header branch September 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Add a command to check that the generated types are in sync
4 participants