chore: run eslint and tsc in missing packages #6090
Conversation
|
threepointone
force-pushed
the
run-eslint-everywhere
branch
from
5e161d9 to
1f2b7d7
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-wrangler-6090You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6090/npm-package-wrangler-6090Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-wrangler-6090 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-create-cloudflare-6090 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-cloudflare-kv-asset-handler-6090npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-miniflare-6090npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-cloudflare-pages-shared-6090npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9584485005/npm-package-cloudflare-vitest-pool-workers-6090Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Some of our packages didn't have a lint/typecheck rule setup, so I added it. Also fixed a couple of failures along the way. I _didn't_ enable linting for kv-asset-handler because that looks like a bit more work, which we can do later.
threepointone
force-pushed
the
run-eslint-everywhere
branch
from
1f2b7d7 to
39515d3
Compare
| @@ -30,7 +30,6 @@ | |||
| "dev:codemod": "node -r esbuild-register scripts/codemodDev.ts", | |||
| "check:lint": "eslint .", | |||
| "check:type": "tsc", | |||
| "lint": "eslint", | |||
There was a problem hiding this comment.
we already have check:lint above this which actually lints the package, this command doesn't do anything
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
added this config so I can locally run eslint, but as mentioned it won't do it in CI yet until I fix all the failures
There was a problem hiding this comment.
I'll leave it up to you, but in case we are not planning on fixing those failures any time soon, we might want to consider flagging what you said ☝️ with a comment, just in case someone wakes up one day with the urge of using this config 😅 . Again, abs up to you!
There was a problem hiding this comment.
I plan on doing it myself soon, filed #6101
| @@ -42,6 +42,7 @@ export function useRefreshableIframe( | |||
| second.removeEventListener("load", onLoadEvent); | |||
| }; | |||
| } | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
this one is a tricky one to fix, excluding it for now
There was a problem hiding this comment.
do we want to keep track of these somehow as to not forget to properly fix them at some point?
| @@ -69,6 +70,7 @@ export function useRefreshableIframe( | |||
| if (src) { | |||
| setUrl(src); | |||
| } | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
this one is a tricky one to fix, excluding it for now
There was a problem hiding this comment.
same question here
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
Followup from #6090, this enables typechecking and linting in kv-asset-handler, and fixes any failures.
Some of our packages didn't have a lint/typecheck rule setup, so I added it. Also fixed a couple of failures along the way. I didn't enable linting for kv-asset-handler because that looks like a bit more work, which we can do later.
No changeset / tests for this, no functional changes.