-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wrangler pages secret put|delete|list|bulk
#5549
Conversation
🦋 Changeset detectedLatest commit: aa583ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-wrangler-5549 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5549/npm-package-wrangler-5549 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-wrangler-5549 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-create-cloudflare-5549 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-cloudflare-kv-asset-handler-5549 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-miniflare-5549 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-cloudflare-pages-shared-5549 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8621208400/npm-package-cloudflare-vitest-pool-workers-5549 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
58505d6
to
41c13f8
Compare
41c13f8
to
bd93e24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions for messaging updates.
Co-authored-by: Adam Murray <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR solves / how to test
This PR supports adding secrets to a Pages project using the Wrangler CLI. Similarly to
wrangler secret
, this PR adds awrangler pages secret
set of commands. There are several differences to the Workers commands:--project
is used to specify the project to target, compared to--name
for Workers.--env=production|preview
secret:bulk
is renamed tosecret bulk
Fixes #5180
Author has addressed the following
wrangler pages secret
cloudflare-docs#13958