-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSP:script-src in 0015-Basic-support-for-Safari.patch (#4737) #4738
Conversation
🦋 Changeset detectedLatest commit: c2d3458 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also don't have the ability to test this locally.
Should we be able to from the Pages preview?
Yes we should, but for some reason that's not currently working. I'm investigating |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4738/npm-package-wrangler-4738 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-create-cloudflare-4738 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-kv-asset-handler-4738 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-miniflare-4738 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-pages-shared-4738 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-vitest-pool-workers-4738 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-editor-shared-4738 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-shared-4738 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Manually tested from a build in #6556 |
Congratulations @neilsh, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm05981x694580cllj4qbvgw3 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Potential fix for #4737. Note that I haven't tested this myself, as I don't have an environment set up for wrangler-devtools -- feel free to modify this from draft->ready once tested.
Fixes #4737
What this PR solves / how to test:
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.