feat: Custom https cert

[paulrostorp]

Fixes #2118

What this PR solves / how to test:
Add flags --https-key-path and --https-cert-path to wrangler pages dev command

Author has addressed the following:

• Tests
  • Included (although the actual feature has only been tested manually by @petebacondarwin)
  • Not necessary because:
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s): Wrangler: Document the new --https-cert-path and --https-key-path options for wrangler dev and wrangler pages dev cloudflare-docs#13032
  • Not necessary because:

[changeset-bot]

⚠️ No Changeset found

Latest commit: bbc7f0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[lrapoport-cf]

blocked for now (see #2118 (comment))

[petebacondarwin]

I know this is blocked for the moment, but I would like to propose a simpler implementation, for when we are in a position to land this. Instead of using command line arguments, which need to be threaded down through the various calls. How about we just have a pair of environment variables, e.g. CLOUDFLARE_LOCAL_HTTPS_KEY_PATH and CLOUDFLARE_LOCAL_HTTPS_CERT_PATH.
Then the implementation would simply check these environment variables in the getHttpsOptions() function before attempting to generate these files.

Is there a reason (e.g. prior art) for doing this via command line arguments that I am missing?

[paulrostorp]

@petebacondarwin I did consider that as it was a much simpler implementation, but considering this CLI aims to support configuration both through flags and a config file (wrangler.toml), I thought it best not to break that pattern.

[petebacondarwin]

@petebacondarwin I did consider that as it was a much simpler implementation, but considering this CLI aims to support configuration both through flags and a config file (wrangler.toml), I thought it best not to break that pattern.

Ah yes and looking through the original issue it seems that there is value in being able to set different certs for each wrangler instance, which is more awkward using env vars - #2118 (comment)

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-wrangler-4475

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4475/npm-package-wrangler-4475

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-wrangler-4475 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-create-cloudflare-4475 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-cloudflare-kv-asset-handler-4475

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-miniflare-4475

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7932008257/npm-package-cloudflare-pages-shared-4475

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240129.2
workerd	1.20240129.0	1.20240129.0
workerd --version	1.20240129.0	2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (55ea072) 70.44% compared to head (bbc7f0a) 70.40%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4475      +/-   ##
==========================================
- Coverage   70.44%   70.40%   -0.05%     
==========================================
  Files         297      297              
  Lines       15431    15448      +17     
  Branches     3951     3960       +9     
==========================================
+ Hits        10871    10876       +5     
- Misses       4560     4572      +12     

Files	Coverage Δ
packages/wrangler/src/api/dev.ts	83.33% <100.00%> (+0.47%)	⬆️
packages/wrangler/src/api/startDevWorker/types.ts	100.00% <ø> (ø)
packages/wrangler/src/dev.tsx	80.30% <ø> (ø)
packages/wrangler/src/dev/local.tsx	27.50% <ø> (ø)
packages/wrangler/src/dev/remote.tsx	7.92% <ø> (ø)
packages/wrangler/src/dev/start-server.ts	78.19% <ø> (ø)
packages/wrangler/src/pages/dev.ts	16.21% <ø> (ø)
packages/wrangler/src/dev/miniflare.ts	63.55% <0.00%> (ø)
...wrangler/src/api/startDevWorker/ProxyController.ts	61.97% <0.00%> (+0.83%)	⬆️
packages/wrangler/src/dev/proxy.ts	4.11% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

[petebacondarwin]

I rebased and fixed up this branch. Will do a proper review later this week.

[Aphanite]

Thanks a lot for this and for including it in the latest release! However, when I searched for the first version to support it, I found no mention of it in the recent releases.

[petebacondarwin]

Gosh! You are right. That is my mistake for landing this without a changeset. It was first available in 3.28.3. I'll update the changelog accordingly.

[petebacondarwin]

#5147