-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: Add bun support #4065
C3: Add bun support #4065
Conversation
🦋 Changeset detectedLatest commit: 11ccda0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-wrangler-4065 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6354060817/npm-package-wrangler-4065 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-wrangler-4065 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-cloudflare-pages-shared-4065 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
a058483
to
7ab7cec
Compare
Quick question.... I think that bun is not really supported on windows right now, and only its runtime is available? (https://bun.sh/docs/installation#windows) Should we add some checks to provide a graceful error message for users trying to use C3 with bun on windows? PS: I don't have a windows machine so I haven't really tested the above 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks James!
As there is now Windows support can this perhaps be redone? @dario-piotrowicz @jculvey |
Fixes #3941.
What this PR solves / how to test:
Adds support for bun along with e2e coverage.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.