Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Add bun support #4065

Merged
merged 5 commits into from
Sep 29, 2023
Merged

C3: Add bun support #4065

merged 5 commits into from
Sep 29, 2023

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Sep 29, 2023

Fixes #3941.

What this PR solves / how to test:

Adds support for bun along with e2e coverage.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested review from a team as code owners September 29, 2023 03:28
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: 11ccda0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-wrangler-4065

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6354060817/npm-package-wrangler-4065

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-wrangler-4065 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6354060817/npm-package-cloudflare-pages-shared-4065

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz
Copy link
Member

Quick question.... I think that bun is not really supported on windows right now, and only its runtime is available? (https://bun.sh/docs/installation#windows)

Should we add some checks to provide a graceful error message for users trying to use C3 with bun on windows?
(Or can we just ignore the bun windows incompatibility and if things don't work for windows users we just blame bun?)

PS: I don't have a windows machine so I haven't really tested the above 😅

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks James!

@jculvey jculvey merged commit 55298d9 into main Sep 29, 2023
@jculvey jculvey deleted the c3-support-bun branch September 29, 2023 16:13
@7heMech
Copy link

7heMech commented Dec 4, 2024

As there is now Windows support can this perhaps be redone? @dario-piotrowicz @jculvey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: Bun Support
4 participants