Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Testing Deps #3976

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

JacobMGEvans
Copy link
Contributor

Upgrading Jest & Vitest with any adjacent tooling. Additionally some more monorepo standardizing.

Upgrading Jest & Vitest with any adjacent tooling
@JacobMGEvans JacobMGEvans added the maintenance Maintenance task label Sep 18, 2023
@JacobMGEvans JacobMGEvans requested a review from a team as a code owner September 18, 2023 21:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: c2f8855

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6228630718/npm-package-wrangler-3976

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6228630718/npm-package-wrangler-3976

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6228630718/npm-package-wrangler-3976 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6228630718/npm-package-cloudflare-pages-shared-3976

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230904.0 3.20230904.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #3976 (c2f8855) into main (7c97afb) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
+ Coverage   75.08%   75.13%   +0.04%     
==========================================
  Files         195      195              
  Lines       11533    11533              
  Branches     3054     3054              
==========================================
+ Hits         8660     8665       +5     
+ Misses       2873     2868       -5     

see 3 files with indirect coverage changes

Comment on lines +98 to +101
"snapshotFormat": {
"escapeString": true,
"printBasicPrototype": true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this cause the snapshots to need updating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents the snapshots from needing updating with the v29 migration
https://jestjs.io/docs/upgrading-to-jest29#snapshot-format

@JacobMGEvans JacobMGEvans merged commit 291c78b into main Sep 19, 2023
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/testing-deps-upgrades branch September 19, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants