fix: pages project delete should error if project name not specified (

#6914) * fix pages project delete demandOption * test
cloudflare · Oct 10, 2024 · a24c86b · a24c86b
1 parent 301d413
commit a24c86b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/wrangler/src/__tests__/pages/project-delete.test.ts b/packages/wrangler/src/__tests__/pages/project-delete.test.ts
@@ -63,6 +63,14 @@ describe("pages project delete", () => {
 	`);
 	});
 
+	it("should error if no project name is specified", async () => {
+		await expect(
+			runWrangler("pages project delete")
+		).rejects.toThrowErrorMatchingInlineSnapshot(
+			`[Error: Missing required argument: project-name]`
+		);
+	});
+
 	it("should not delete a project if confirmation refused", async () => {
 		mockConfirm({
 			text: `Are you sure you want to delete "some-project-name-2"? This action cannot be undone.`,

diff --git a/packages/wrangler/src/pages/projects.tsx b/packages/wrangler/src/pages/projects.tsx
@@ -188,7 +188,6 @@ export function DeleteOptions(yargs: CommonYargsArgv) {
 	return yargs
 		.positional("project-name", {
 			type: "string",
-			demandOption: true,
 			description: "The name of your Pages project",
 		})
 		.options({
@@ -197,7 +196,8 @@ export function DeleteOptions(yargs: CommonYargsArgv) {
 				type: "boolean",
 				description: 'Answer "yes" to confirm project deletion',
 			},
-		});
+		})
+		.demandOption("project-name");
 }
 
 export async function DeleteHandler(