Skip to content

Commit

Permalink
update patches
Browse files Browse the repository at this point in the history
  • Loading branch information
emily-shen committed Jan 7, 2025
1 parent a7b0488 commit 9f2805f
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 25 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From f33a1c016aca11dd75e912ba3373be01fc7480da Mon Sep 17 00:00:00 2001
From 2af0fbb31bccc471b304849cc57658a9e853c7b8 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 14:15:43 +0100
Subject: [PATCH 1/8] Expand Browser support (make it work in Firefox & Safari)
Expand All @@ -23,7 +23,7 @@ If updating the commit of devtools upon which these patches are based, make sure
4 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/front_end/core/dom_extension/DOMExtension.ts b/front_end/core/dom_extension/DOMExtension.ts
index 940ce81924..e9542743ff 100644
index 5060011dba..1ca615e641 100644
--- a/front_end/core/dom_extension/DOMExtension.ts
+++ b/front_end/core/dom_extension/DOMExtension.ts
@@ -132,7 +132,7 @@ Node.prototype.getComponentSelection = function(): Selection|null {
Expand All @@ -33,7 +33,7 @@ index 940ce81924..e9542743ff 100644
- return parent instanceof ShadowRoot ? parent.getSelection() : this.window().getSelection();
+ return parent instanceof ShadowRoot ? (parent?.getSelection?.() ?? this.window().getSelection()) : this.window().getSelection();
};

Node.prototype.hasSelection = function(): boolean {
diff --git a/front_end/entrypoint_template.html b/front_end/entrypoint_template.html
index 8e0e11ca35..0d422c3cda 100644
Expand Down Expand Up @@ -100,18 +100,18 @@ index 45028f436a..6a154030b6 100644
static instance(opts: {forceNew: boolean|null} = {forceNew: null}): JsMainImpl {
const {forceNew} = opts;
diff --git a/front_end/ui/legacy/components/data_grid/DataGrid.ts b/front_end/ui/legacy/components/data_grid/DataGrid.ts
index 93a117e746..d9e37e3d7a 100644
index 24f6b09d0c..8b9ca969ae 100644
--- a/front_end/ui/legacy/components/data_grid/DataGrid.ts
+++ b/front_end/ui/legacy/components/data_grid/DataGrid.ts
@@ -217,6 +217,8 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
this.headerRow = this.dataTableHeadInternal.createChild('tr');

this.dataTableBody = this.dataTable.createChild('tbody');
+ // This is required for Firefox, else Firefox will position the <tbody/> *under* the <thead/>
+ (this.dataTableBody as HTMLElement).style.height = 'calc(100% - 27px)';
this.topFillerRow = (this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed') as HTMLElement);
this.topFillerRow = this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed');
UI.ARIAUtils.setHidden(this.topFillerRow, true);
this.bottomFillerRow = (this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed') as HTMLElement);
this.bottomFillerRow = this.dataTableBody.createChild('tr', 'data-grid-filler-row revealed');
@@ -505,6 +507,9 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
protected setVerticalPadding(top: number, bottom: number, isConstructorTime: boolean = false): void {
const topPx = top + 'px';
Expand All @@ -122,6 +122,6 @@ index 93a117e746..d9e37e3d7a 100644
if (this.topFillerRow.style.height === topPx && this.bottomFillerRow.style.height === bottomPx) {
return;
}
--
--
2.39.5 (Apple Git-154)

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 6fbdae0bba47eeb10a779fbfbb15bbe6f17fa798 Mon Sep 17 00:00:00 2001
From b270f282cb8652f8a878bfdc2594bb6aa329f512 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 16:06:06 +0100
Subject: [PATCH 2/8] Setup Cloudflare devtools target type
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 233ae8633d7a84f662ebdea564070fcbee2f42d4 Mon Sep 17 00:00:00 2001
From bb83ff914007d15f52e4eaf46b6f52e102631163 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 15:04:17 +0100
Subject: [PATCH 3/8] Add ping to improve connection stability. Without this,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From f55dc8200dda3025eb7866f2706a08851aa0d3dd Mon Sep 17 00:00:00 2001
From 279a5fc3067a3c1d2eee648bdc94e21b32124e88 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 15:26:38 +0100
Subject: [PATCH 4/8] Support viewing source files over the network. This
Expand All @@ -23,7 +23,7 @@ Subject: [PATCH 4/8] Support viewing source files over the network. This
6 files changed, 15 insertions(+), 40 deletions(-)

diff --git a/front_end/core/common/ParsedURL.ts b/front_end/core/common/ParsedURL.ts
index 832d76c19c..968439ade4 100644
index 100d9ec45f..d75d6e4f2f 100644
--- a/front_end/core/common/ParsedURL.ts
+++ b/front_end/core/common/ParsedURL.ts
@@ -366,7 +366,7 @@ export class ParsedURL {
Expand Down Expand Up @@ -88,20 +88,20 @@ index 1a6644df92..1724a33bd4 100644
persistence: UI.ViewManager.ViewPersistence.PERMANENT,
async loadView() {
diff --git a/front_end/entrypoints/main/MainImpl.ts b/front_end/entrypoints/main/MainImpl.ts
index 978092dea5..fc463ec0c9 100644
index fbc6a1bd71..e6bc57bbb0 100644
--- a/front_end/entrypoints/main/MainImpl.ts
+++ b/front_end/entrypoints/main/MainImpl.ts
@@ -421,6 +421,8 @@ export class MainImpl {
Root.Runtime.ExperimentName.TIMELINE_ANNOTATIONS,
@@ -414,6 +414,8 @@ export class MainImpl {
Root.Runtime.ExperimentName.NETWORK_PANEL_FILTER_BAR_REDESIGN,
Root.Runtime.ExperimentName.FLOATING_ENTRY_POINTS_FOR_AI_ASSISTANCE,
Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
+ Root.Runtime.ExperimentName.AUTHORED_DEPLOYED_GROUPING,
+ Root.Runtime.ExperimentName.JUST_MY_CODE,
...(Root.Runtime.Runtime.queryParam('isChromeForTesting') ? ['protocol-monitor'] : []),
]);

diff --git a/front_end/panels/sources/NavigatorView.ts b/front_end/panels/sources/NavigatorView.ts
index 6f4c52f3e7..2f5ada52e6 100644
index d9da41ab84..73f42a22be 100644
--- a/front_end/panels/sources/NavigatorView.ts
+++ b/front_end/panels/sources/NavigatorView.ts
@@ -795,8 +795,9 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
Expand All @@ -117,7 +117,7 @@ index 6f4c52f3e7..2f5ada52e6 100644

const parsedURL = new Common.ParsedURL.ParsedURL(projectOrigin);
diff --git a/front_end/panels/sources/sources-meta.ts b/front_end/panels/sources/sources-meta.ts
index 42a2e17f07..c41a8d2c7a 100644
index f4284da33b..76bb296abb 100644
--- a/front_end/panels/sources/sources-meta.ts
+++ b/front_end/panels/sources/sources-meta.ts
@@ -495,32 +495,6 @@ UI.ViewManager.registerViewExtension({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 0f7a1adad6b0bfbafe60fbc4c161fa9a7ef0381f Mon Sep 17 00:00:00 2001
From 318c4c1007ceffc8f4d7d34203017aa17c00c6ff Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 15:05:56 +0100
Subject: [PATCH 5/8] Support forcing the devtools theme via a query parameter,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 3b484138dabb583349363df0e2d69ffe3c1dc039 Mon Sep 17 00:00:00 2001
From 56be29aa34a1e37d95e640a79d4243f1105bff81 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 16:05:12 +0100
Subject: [PATCH 6/8] All about the network tab!
Expand All @@ -16,7 +16,7 @@ Subject: [PATCH 6/8] All about the network tab!
4 files changed, 9 insertions(+), 28 deletions(-)

diff --git a/front_end/core/sdk/NetworkManager.ts b/front_end/core/sdk/NetworkManager.ts
index 8735116e61..953d3fc7b1 100644
index 4093f80cf8..1eb3199a53 100644
--- a/front_end/core/sdk/NetworkManager.ts
+++ b/front_end/core/sdk/NetworkManager.ts
@@ -34,6 +34,7 @@
Expand Down Expand Up @@ -73,7 +73,7 @@ index 1724a33bd4..884c6264d2 100644

import * as Common from '../../core/common/common.js';
diff --git a/front_end/panels/network/NetworkPanel.ts b/front_end/panels/network/NetworkPanel.ts
index 71c40a6873..abf30cc4e8 100644
index 7d44f68bf3..f4b7ec0973 100644
--- a/front_end/panels/network/NetworkPanel.ts
+++ b/front_end/panels/network/NetworkPanel.ts
@@ -75,14 +75,6 @@ const UIStrings = {
Expand All @@ -91,7 +91,7 @@ index 71c40a6873..abf30cc4e8 100644
/**
*@description Tooltip text that appears when hovering over the largeicon settings gear in show settings pane setting in network panel of the network panel
*/
@@ -158,10 +150,6 @@ const UIStrings = {
@@ -180,10 +172,6 @@ const UIStrings = {
*@description Text in Network Panel that is displayed when frames are being fetched.
*/
fetchingFrames: 'Fetching frames...',
Expand All @@ -102,7 +102,7 @@ index 71c40a6873..abf30cc4e8 100644
};
const str_ = i18n.i18n.registerUIStrings('panels/network/NetworkPanel.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -422,21 +410,6 @@ export class NetworkPanel extends UI.Panel.Panel implements
@@ -444,21 +432,6 @@ export class NetworkPanel extends UI.Panel.Panel implements
this.panelToolbar.appendToolbarItem(new UI.Toolbar.ToolbarSettingCheckbox(
this.preserveLogSetting, i18nString(UIStrings.doNotClearLogOnPageReload), i18nString(UIStrings.preserveLog)));

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 01012531546fccc62536fba7d1bfde6c5cc1a6c2 Mon Sep 17 00:00:00 2001
From 5628440eb60352e14738ef4c19986398e0c5681e Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 16:07:24 +0100
Subject: [PATCH 7/8] Limit heap profiling modes available
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 57b100b2455fc3adb794218c4d15c44052a16f52 Mon Sep 17 00:00:00 2001
From 6371a3e8fa36ae2d0c85396ab770e5428e9951f3 Mon Sep 17 00:00:00 2001
From: Workers DevProd <[email protected]>
Date: Fri, 25 Oct 2024 16:11:10 +0100
Subject: [PATCH 8/8] Use the worker name as the title for the Javascript
Expand Down

0 comments on commit 9f2805f

Please sign in to comment.