Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a lot of difficulty getting the tests working in this repo. I had issues with not including the tests in workers-kv as a member of the main
Cargo.toml
. There were also issues with the versioning of the various nestedCargo.toml
files. I think it would probably be prudent to separate theworkers-kv/tests
into its own member. I have not yet seen rust-based tests anywhere else in this repo so I wanted to get feedback on that.I will make a follow-up pull request for updated dependencies and separation of testing modules. I will also look into updating the tests to use Miniflare 3 instead of Miniflare 1.