Fail cc_ast_dump when AST dump encounters errors, add missing dependencies to API AST dump #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies to API AST dump PR #2991 introduced a regression where the API AST dump did not have access to all the required includes. However, an incomplete AST was still being generated despite the missing include error. Add the missing dependencies so that the correct types are generated and enable pipefail for the ast dump/gzip shell commands so that the cc_ast_dump action fails if there are any errors being reported.
danlapid
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2991 introduced a regression where the API AST dump did not have access to all the required includes. However, an incomplete AST was still being generated despite the missing include error. Add the missing dependencies so that the correct types are generated and enable pipefail for the ast dump/gzip shell commands so that the cc_ast_dump action fails if there are any errors being reported.