Add experimental method to create DO replicas #2824
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
force-pushed
the
milan/create-replicas
branch
from
6da190e
to
ea2b618
Compare
MellowYarker
force-pushed
the
milan/create-replicas
branch
from
ea2b618
to
0436dae
Compare
MellowYarker
force-pushed
the
milan/create-replicas
branch
from
0436dae
to
9e46063
Compare
justin-mp
approved these changes
Nov 1, 2024
jasnell
reviewed
Nov 3, 2024
| @@ -3362,4 +3362,8 @@ kj::Promise<void> ActorCacheInterface::waitForBookmark(kj::StringPtr bookmark) { | |||
| Error, "This Durable Object's storage back-end does not implement point-in-time recovery."); | |||
| } | |||
|
|
|||
| void ActorCacheInterface::ensureReplicas() { | |||
| JSG_FAIL_REQUIRE(Error, "This Durable Object's storage back-end does not support replication."); | |||
There was a problem hiding this comment.
Nit: Can you add a comment along the lines of this being intended to be implemented internally
jasnell
reviewed
Nov 3, 2024
| @@ -239,6 +239,8 @@ class ActorCacheInterface: public ActorCacheOps { | |||
| virtual kj::Promise<kj::String> getBookmarkForTime(kj::Date timestamp); | |||
| virtual kj::Promise<kj::String> onNextSessionRestoreBookmark(kj::StringPtr bookmark); | |||
| virtual kj::Promise<void> waitForBookmark(kj::StringPtr bookmark); | |||
|
|
|||
| virtual void ensureReplicas(); | |||
There was a problem hiding this comment.
Given that it's just a throw, consider just inlining the implementation with the throw here. Just keeps things a bit simpler.
jasnell
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.