You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use shared linkage for tests – cc_test uses shared linkage by default. This allows us to compile benchmark binaries for CI debug/ASAN builds, which would otherwise be prohibitively large.
@mikea Any concerns about shared linkage affecting benchmark performance? If it would make benchmarking less accurate we could disable it in the benchmark/profile configurations.
Looks like this doesn't work on Windows 🫤
I've seen issues with shared linkage there before, might keep this disabled for a bit still, might have to only enable this on Linux only and keep the benchmarks disabled on other platforms for now.
We already use shared linkage for tests – cc_test uses shared linkage by
default. This allows us to compile benchmark binaries for CI debug/ASAN
builds, which would otherwise be prohibitively large. For now, this is
only enabled on Linux.
Investigated what it would take to support shared linkage on Windows – apparently global variables that should be visible across libraries need to be specifically annotated as __declspec(dllimport), so bazel's approach of allowing any library to implicitly be shared won't work without extensive code changes. Only having this on Linux is not ideal, but at least we'll have them compiled with asan/debug somewhere.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fhanau
force-pushed
the
felix/shared-bench
branch
from
We already use shared linkage for tests –
cc_testuses shared linkage by default. This allows us to compile benchmark binaries for CI debug/ASAN builds, which would otherwise be prohibitively large.