provider: Use real Terraform version in UA header #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
patryk
approved these changes
Aug 1, 2019
|
@radeksimko Looks like hashicorp/terraform#22272 has landed, is this ready for merge now? |
|
We are in the process of resolving some upstream dependency issues before we cut the next version and update this PR, please hold. |
radeksimko
force-pushed
the
f-user-agent
branch
from
9f8288b to
4e2667e
Compare
radeksimko
force-pushed
the
f-user-agent
branch
from
4e2667e to
0b8b5d7
Compare
radeksimko
force-pushed
the
f-user-agent
branch
from
0b8b5d7 to
7dee496
Compare
|
@patryk I have updated the description of the PR so you can understand the full impact which may not be immediately obvious + I rebased to the latest Could you please confirm you're ok with it and happy for me to merge? |
|
Thanks @radeksimko, great to see it in! |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation leverages Terraform's
versionpackage as Terraform currently provides the SDK for interacting with core and is therefore imported by the provider, including theversionpackage.The side effect of this is that provider reports version of vendored Terraform (i.e. plugin SDK), not the version which actually talks to the provider's gRPC server and parses the configuration.
This PR is leveraging recent changes introduced in 0.12 to fix that and report accurate version.
This also changes the header from the following
to
to align UA string with hashicorp/terraform#22272