Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event types #51

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Fix event types #51

merged 3 commits into from
Feb 9, 2022

Conversation

TheDuc
Copy link
Contributor

@TheDuc TheDuc commented Dec 21, 2021

The types for the event listeners are not of type EventListener as per documentation, so you would get an error:

onPlay={(e) => console.log(e)}

Type error: Type '(e) => void' is not assignable to type '() => void'.

@TheDuc
Copy link
Contributor Author

TheDuc commented Jan 31, 2022

Any updates on this?

@third774
Copy link
Contributor

third774 commented Jan 31, 2022 •
edited
Loading

Hey, @TheDuc — thanks for the PR! We'll take a look at this soon!

@third774 third774 self-requested a review February 1, 2022 03:55
third774
third774 requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@third774 third774 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for submitting this!

src/types.ts Show resolved Hide resolved
@third774 third774 self-requested a review February 9, 2022 17:15
@third774 third774 merged commit 9a6c3e3 into cloudflare:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@third774 third774 third774 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDuc @third774