Prevent modal from closing when modal is partial target of click #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000hz
force-pushed
the
fix-modal-close-behavior
branch
from
54ae531 to
e45e44b
Compare
nickbalestra
approved these changes
Aug 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user starts a click on the modal and ends it elsewhere (or vice versa) the modal is not prevented from closing. This is not a great experience, since the user might be trying to select text inside of an input or accidentally started their click outside the modal and doesn't intend to actually close it.
This PR prevents the modal from closing if the modal is the target of either the mousedown or mouseup phase of the click.
Fixes #29