Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish version v5 #26

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Publish version v5 #26

merged 1 commit into from
Jul 24, 2017

Conversation

tajo
Copy link
Contributor

@tajo tajo commented Jul 24, 2017

No description provided.

@tajo tajo requested a review from jwineman July 24, 2017 19:31
@jwineman
Copy link
Contributor

I'm fine with this but is there a specific reason you want to release 5.0.0 after we deprecated 4.0.0?

@tajo
Copy link
Contributor Author

tajo commented Jul 24, 2017

@jwineman 2 reasons:

  1. We want to avoid situation that someone will publish v4.x.x again which could easily happen if they were not involved in this convo.
  2. It's a bit weird to deprecate a version and not providing higher version (asking people to do major downgrade).

@tajo tajo merged commit 0bee6ec into cloudflare:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwineman jwineman jwineman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tajo @jwineman