Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refs to callbacks for Fiber compat #19

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

jaredpalmer
Copy link
Contributor

Out of the box, when running a jest snapshot with React 16 alpha, I got this error:

TypeError: getStackAddendumByWorkInProgressFiber is not a function

      at captureError (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:889:29)
      at commitAllWork (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:400:9)
      at completeUnitOfWork (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:522:11)
      at performUnitOfWork (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:546:14)
      at workLoop (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:666:26)
      at performWork (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:707:30)
      at scheduleUpdate (../node_modules/react-test-renderer/lib/ReactFiberScheduler.js:1060:15)
      at scheduleTopLevelUpdate (../node_modules/react-test-renderer/lib/ReactFiberReconciler.js:60:5)
      at Object.updateContainer (../node_modules/react-test-renderer/lib/ReactFiberReconciler.js:90:7)
      at Object.create (../node_modules/react-test-renderer/lib/ReactTestRendererFiber.js:237:18)

This PR mitigates this error by replacing all string refs with callbacks.

@jamiebuilds jamiebuilds merged commit 0167c25 into cloudflare:master Mar 14, 2017
@jwineman
Copy link
Contributor

Thanks!

@jaredpalmer
Copy link
Contributor Author

Should we bump dependency to include 16 too?

https://github.com/cloudflare/react-modal2/blob/master/package.json#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants