improve bundled assets handling #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 871f784 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/5552609824/npm-package-next-on-pages-325@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/5552609824/npm-package-eslint-plugin-next-on-pages-325 |
GregBrimble
reviewed
Jun 23, 2023
GregBrimble
reviewed
Jun 23, 2023
packages/next-on-pages/src/buildApplication/generateGlobalJs.ts
Outdated
Show resolved
Hide resolved
dario-piotrowicz
force-pushed
the
improve-bin-assets-handling
branch
2 times, most recently
from
d555515 to
25e5902
Compare
1 task
dario-piotrowicz
force-pushed
the
improve-bin-assets-handling
branch
3 times, most recently
from
60c88bc to
a5d4b8b
Compare
1 task
|
PS: these changes should replicate the fetchInlineAsset's functionality (I think they do) |
dario-piotrowicz
force-pushed
the
improve-bin-assets-handling
branch
from
a5d4b8b to
8680420
Compare
GregBrimble
reviewed
Jul 12, 2023
| const assetsDir = join(distDir, 'assets'); | ||
| await mkdir(assetsDir); | ||
| for (const { filename, originalFileLocation } of bundledAssetsInfo.values()) { | ||
| const newLocation = join(assetsDir, `${filename}.bin`); |
There was a problem hiding this comment.
This saddens me :(
We need to give frameworks a way to emit a manifest with content-types which Wrangler can pick up cc. @RamIdeas .
GregBrimble
reviewed
Jul 12, 2023
GregBrimble
reviewed
Jul 12, 2023
GregBrimble
approved these changes
Jul 12, 2023
dario-piotrowicz
force-pushed
the
improve-bin-assets-handling
branch
from
659249c to
146cc26
Compare
GregBrimble
approved these changes
Jul 13, 2023
packages/next-on-pages/src/buildApplication/generateFunctionsMap.ts
Outdated
Show resolved
Hide resolved
Kebab11noel
pushed a commit
to Likespace-Kft/next-on-pages
that referenced
this pull request
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to handle vercel asset fetches such as the one present in this example: https://vercel.com/docs/concepts/functions/edge-functions/og-image-generation/og-image-examples#using-a-custom-font
Which makes it possible to use
@vercel/og🚀 😄Result:
simple-wasm-pages-13.3.1 deployed at: https://a9aeda25.next-on-pages-test-5h3.pages.dev
resolves #39