-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use vercel fork #239
use vercel fork #239
Conversation
|
🧪 A prerelease is available for testing 🧪 You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/4989651998/npm-package-next-on-pages-239 Or you can immediately run this with npx https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/4989651998/npm-package-next-on-pages-239 |
Co-authored-by: James <[email protected]>
IMO this PR (and maybe even the changeset) needs a bit more information about what this fork is, what it does, and why it is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd for sure pin the version, and I'd strongly consider removing any reference to this in public docs.
Where is the fork? If not in the Cloudflare org, I think it should be open-source at least somewhere (your personal account?) so inquisitive folks can see what code we're running. |
It's in the PR's description (I had the link wrong, I've just updated it 🙇) I hope that's enough |
no sorry it's a leftover of my debugging 😓, I've removed that, updated the next-on-pages dependency and updated the PR's description with the latest commit, thanks for noticing it 🙂 |
This PR makes Pages CI build using the new v2 beta image work.
The issue is that the current Vercel CLI opens too many file handlers at once (which the v2 beta image doesn't seem to be handling correctly) when building a Next.js >= v.13.3.0 app that contains prerendered routes.
The prerendered routes are problematic because as part of the building process Vercel generates lambda functions for them, such lambda functions include node modules, the parallel downloading of such node modules causes too many files to be open at once.
This PR introduces as a temporary fix the use of a fork of the Vercel CLI that sequentializes the above mentioned problematic downloads solving the issue (see dario-piotrowicz/vercel@4f63551).
This is meant to be a very temporary fix to be in place only until the v2 image has been fixed/improved to handle more files handlers at once.
I've tested it with the following apps from my testing apps repo:
https://d8933adb.next-on-pages-ci-testing-app.pages.dev/
https://2283cf03.next-on-pages-ci-testing-app.pages.dev/
https://c97fecc1.next-on-pages-ci-testing-app.pages.dev/
https://0a517f38.next-on-pages-ci-testing-app.pages.dev/
https://7a1e4ab6.next-on-pages-ci-testing-app.pages.dev/