Skip to content

Commit

Permalink
remove no-app-not-found-runtime eslint rule in a backward compatibl…
Browse files Browse the repository at this point in the history
…e manner (#600)
  • Loading branch information
dario-piotrowicz authored Dec 21, 2023
1 parent eb4d28c commit ed9a4ac
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 172 deletions.
5 changes: 5 additions & 0 deletions .changeset/moody-chefs-dress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-next-on-pages': patch
---

remove the no-longer-necessary `no-app-not-found-runtime` rule in a backward compatible manner

This file was deleted.

6 changes: 3 additions & 3 deletions packages/eslint-plugin-next-on-pages/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import noNodeJsRuntime from './rules/no-nodejs-runtime';
import noUnsupportedConfigs from './rules/no-unsupported-configs';
import noAppNotFoundRuntime from './rules/no-app-not-found-runtime';

import type { ESLint } from 'eslint';

const config: ESLint.Plugin = {
rules: {
'no-nodejs-runtime': noNodeJsRuntime,
'no-unsupported-configs': noUnsupportedConfigs,
'no-app-not-found-runtime': noAppNotFoundRuntime,
// the following rule is no longer needed/applicable, it has been converted into a noop (so that it doesn't introduce a breaking change)
// it should be removed in the next package major release
'no-app-not-found-runtime': () => ({}),
},
configs: {
recommended: {
plugins: ['eslint-plugin-next-on-pages'],
rules: {
'next-on-pages/no-app-not-found-runtime': 'error',
'next-on-pages/no-nodejs-runtime': 'error',
'next-on-pages/no-unsupported-configs': 'error',
},
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit ed9a4ac

Please sign in to comment.