add missing awaits for getPackageVersion calls (#317)

* add missing await for Relevant Packages info

* add eslint rules to help with Promises & Async/Await

.changeset/breezy-ducks-knock.md

@@ -0,0 +1,5 @@
+---
+'@cloudflare/next-on-pages': patch
+---
+
+fix --info showing [object Promise] for relevant packages instead of their versions

.changeset/pink-actors-learn.md

@@ -0,0 +1,5 @@
+---
+'@cloudflare/next-on-pages': patch
+---
+
+fix vercel command not found issue

internal-packages/eslint-config-next-on-pages/index.js

@@ -1,26 +1,33 @@
 module.exports = {
-	"env": {
-		"es2021": true,
-		"node": true
+	env: {
+		es2021: true,
+		node: true
 	},
-	"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
-	"overrides": [],
-	"parser": "@typescript-eslint/parser",
-	"parserOptions": {
-		"sourceType": "module",
-		"project": true
+	extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+	overrides: [],
+	parser: "@typescript-eslint/parser",
+	parserOptions: {
+		sourceType: "module",
+		project: true
 	},
-	"plugins": ["@typescript-eslint"],
-	"rules": {
+	plugins: ["@typescript-eslint"],
+	rules: {
 		"no-case-declarations": "error",
 		"no-console": "error",
 		"prefer-const": "error",
 		"no-mixed-spaces-and-tabs": "off", // off because it conflicts with prettier
 		"eqeqeq": "error",
-
 		"@typescript-eslint/no-explicit-any": "error",
 		"@typescript-eslint/no-unused-vars": "error",
-		"@typescript-eslint/consistent-type-imports": "error"
+		"@typescript-eslint/consistent-type-imports": "error",
+
+		// Promises & async/await
+		"no-async-promise-executor": "error",
+		"no-promise-executor-return": "error",
+		"no-return-await": "error",
+		"@typescript-eslint/await-thenable": "error",
+		"@typescript-eslint/no-floating-promises": "error",
+		"@typescript-eslint/promise-function-async": "error",
 	},
-	"ignorePatterns": ["vitest.config.ts"]
+	ignorePatterns: ["vitest.config.ts"]
 };

packages/next-on-pages/src/buildApplication/buildVercelOutput.ts

@@ -124,7 +124,7 @@ async function getVercelBuildChildProcess(
 async function isVercelPackageInstalled(
 	pkgMng: PackageManager
 ): Promise<boolean> {
-	const packageVersion = getPackageVersion('vercel', pkgMng);
+	const packageVersion = await getPackageVersion('vercel', pkgMng);
 	return !!packageVersion;
 }
 

packages/next-on-pages/src/cli.ts

@@ -225,8 +225,8 @@ export async function printEnvInfo(): Promise<void> {
 		Package Manager Used: ${await getCurrentPackageManager()}
 		Relevant Packages:
 			@cloudflare/next-on-pages: ${nextOnPagesVersion}
-			vercel: ${getPackageVersion('vercel', packageManager) ?? 'N/A'}
-			next: ${getPackageVersion('next', packageManager) ?? 'N/A'}
+			vercel: ${(await getPackageVersion('vercel', packageManager)) ?? 'N/A'}
+			next: ${(await getPackageVersion('next', packageManager)) ?? 'N/A'}
 	`);
 
 	// eslint-disable-next-line no-console

packages/next-on-pages/src/index.ts

@@ -1,16 +1,16 @@
 import { watch } from 'chokidar';
 import pLimit from 'p-limit';
 import type { CliOptions } from './cli';
-import { cliWarn } from './cli';
+import { cliWarn, cliError } from './cli';
 import { cliLog, parseCliArgs, printCliHelpMessage, printEnvInfo } from './cli';
 import { buildApplication } from './buildApplication';
 import { nextOnPagesVersion } from './utils';
 
 const limit = pLimit(1);
 
-runNextOnPages();
+void runNextOnPages();
 
-function runNextOnPages(): void {
+async function runNextOnPages(): Promise<void> {
 	const args = parseCliArgs();
 
 	if (args.version) {
@@ -19,7 +19,7 @@ function runNextOnPages(): void {
 		return;
 	}
 	if (args.info) {
-		printEnvInfo();
+		await printEnvInfo();
 		return;
 	}
 
@@ -62,7 +62,7 @@ function runBuild(options: CliOptions) {
 				`);
 			}
 		}
-	});
+	}).catch(error => cliError(`Watch mode unexpected error: ${error}`));
 }
 
 function setWatchMode(fn: () => void): void {

packages/next-on-pages/src/utils/fs.ts

@@ -76,7 +76,7 @@ async function validatePathType(path: string, type: 'file' | 'directory') {
  * @param path Path to check.
  * @returns Whether a file exists at the given path.
  */
-export function validateFile(path: string) {
+export async function validateFile(path: string) {
 	return validatePathType(path, 'file');
 }
 
@@ -86,7 +86,7 @@ export function validateFile(path: string) {
  * @param path Path to check.
  * @returns Whether a directory exists at the given path.
  */
-export function validateDir(path: string) {
+export async function validateDir(path: string) {
 	return validatePathType(path, 'directory');
 }
 
@@ -104,9 +104,7 @@ export async function readPathsRecursively(dir: string): Promise<string[]> {
 			files.map(async file => {
 				const path = resolve(dir, file);
 
-				return (await validateDir(path))
-					? await readPathsRecursively(path)
-					: [path];
+				return (await validateDir(path)) ? readPathsRecursively(path) : [path];
 			})
 		);