fix require-call typo in nodeBufferPlugin (#200)

* fix require-call typo in nodeBufferPlugin

resolves #199

* add useful comment to require-call check

* apply suggested refactoring and add another comment

.changeset/swift-islands-doubt.md

@@ -0,0 +1,5 @@
+---
+'@cloudflare/next-on-pages': patch
+---
+
+fix require-call typo preventing nodeBufferPlugin from properly working

src/buildApplication/buildWorkerFile.ts

@@ -83,14 +83,19 @@ const nodeBufferPlugin: Plugin = {
 	name: 'node:buffer',
 	setup(build) {
 		build.onResolve({ filter: /^node:buffer$/ }, ({ kind, path }) => {
-			if (kind === 'require-call') return;
-
-			return {
-				path,
-				namespace: 'node-buffer',
-			};
+			// this plugin converts `require("node:buffer")` calls, those are the only ones that
+			// need updating (esm imports to "node:buffer" are totally valid), so here we tag with the
+			// node-buffer namespace only imports that are require calls
+			return kind === 'require-call'
+				? {
+						path,
+						namespace: 'node-buffer',
+				  }
+				: undefined;
 		});
 
+		// we convert the imports we tagged with the node-buffer namespace so that instead of `require("node:buffer")`
+		// they import from `export * from 'node:buffer;'`
 		build.onLoad({ filter: /.*/, namespace: 'node-buffer' }, () => ({
 			contents: `export * from 'node:buffer'`,
 			loader: 'js',