-
Notifications
You must be signed in to change notification settings - Fork 131
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix wasmImportsToPrepend overriding existing imports (#495)
* fix wasmImportsToPrepend overriding existing imports when dealing with wasms that have more than 1 consumer, when we collect the wasm imports to prepend for a specific edge funcion we're always re-setting the array of wasm imports instead of appending them, this causes edge functions to always only consider the last wasm import, fix such issue resolves #494
- Loading branch information
1 parent
5af0ca3
commit 6600d2a
Showing
2 changed files
with
21 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
'@cloudflare/next-on-pages': patch | ||
--- | ||
|
||
fix wasms not always getting imported when necessary | ||
|
||
Details: | ||
when dealing with wasms that have more than 1 consumer, when we collect | ||
the wasm imports to prepend for a specific edge funcion we're always | ||
re-setting the array of wasm imports instead of appending them, this | ||
causes edge functions to always only consider the last wasm | ||
import, the changes here fix such behavior |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters