-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for multi-architecture images and binaries #184
Conversation
Will this work on the newly released m6g/graviton2 processors from AWS as well? |
Bump** |
@xunholy Hi! Sorry this took a while. We'll get this reviewed in a day or so and get it merged! Thank you so much for your contribution~ |
Thanks @sssilver & @acmacalister - I just wasn't sure what the process was to have this reviewed. Appreciate your time 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this doesnt support windows builds. GOOS=windows fails.
Also, could you please squash these commits into one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xunholy looks good, thanks for your PR! As @Michael9127 noted, can we add Windows as build arch?
Allow Dockerfile --build-args to override GOOS and GOARCH defaults Support building multi architecture binaries remove default OS and ARCH to avoid tag confusion when compiling image through Makefile Tag image with corrosponding OS and ARCH build variables updating Makefile Signed-off-by: Michael Fornaro <[email protected]>
I've squashed commits as requested, usually, I find it easier to just squash and merge but I'm easy either way. |
Just used the logic
Not sure when this was last tested however, I could see Once I removed the duplicate windows build works fine. @Michael9127 @acmacalister |
Signed-off-by: Michael Fornaro <[email protected]>
Thanks @xunholy. Surprised it has a build error, as we distribute Windows builds on every release |
No worries, using the command I mentioned and with the small fix I can build windows fine with these changes. Please let me know if there is anything else you'd like from my end. |
* Allow Dockerfile --build-args to override GOOS and GOARCH defaults Allow Dockerfile --build-args to override GOOS and GOARCH defaults Support building multi architecture binaries remove default OS and ARCH to avoid tag confusion when compiling image through Makefile Tag image with corrosponding OS and ARCH build variables updating Makefile Signed-off-by: Michael Fornaro <[email protected]> * remove duplicate import on windows_service.go Signed-off-by: Michael Fornaro <[email protected]>
Fixes:
Note: Should also consider consolidating the following pull request if you wish to support releasing the binary.