Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: allow clearing comments from the Go API #1166

Closed
wants to merge 2 commits into from
Closed

fix!: allow clearing comments from the Go API #1166

wants to merge 2 commits into from

Commits on Jan 6, 2023

  1. fix!: allow clearing comments from the Go API 

    Currently, empty DNS record comments will be understood as "unset" or
"unspecified", making it impossible to clear a comment. This commit
fixes that.

This is a breaking change, but since comments were introduced only in
0.58.0, chances are almost no applications depend on them yet.
    @favonia
    favonia committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    b65617e View commit details
    Browse the repository at this point in the history

  2. fix!: use pointer type for all DNS record comments

    @favonia
    favonia committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    321392d View commit details
    Browse the repository at this point in the history