Don't return shutdown errors during shutdown #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jan 31, 2022
tokio-boring/src/lib.rs
Outdated
Comment on lines
257
to
264
| // If boring returns PROTOCOL_IS_SHUTDOWN then the connection | ||
| // has already been shutdown and we can just return Ok(()), as | ||
| // this was exactly what we wanted to do anyway. | ||
| if e.code() == ErrorCode::SSL { | ||
| if let Some(stack) = e.ssl_error() { | ||
| if let Some(first) = stack.errors.first() { | ||
| if first.code() as i32 == boring_sys::SSL_R_PROTOCOL_IS_SHUTDOWN { | ||
| return Poll::Ready(Ok(())); |
There was a problem hiding this comment.
Hmm, could we do this in boring::ssl::SslStream instead of tokio-boring? It seems like something that's generally useful, not just when using tokio.
There was a problem hiding this comment.
boring::ssl::SslStream felt more low-level to me, are you sure you want me to move it there?
In production with real-world websites. |
nox
force-pushed
the
shutdown
branch
3 times, most recently
from
85c2e8a
to
439a549
Compare
nox
commented
Dec 6, 2022
boring/src/ssl/mod.rs
Outdated
| if let Some(stack) = e.ssl_error() { | ||
| if let Some(first) = stack.errors.first() { | ||
| if first.code() as i32 == boring_sys::SSL_R_PROTOCOL_IS_SHUTDOWN { | ||
| return Poll::Ready(Ok(ShutdownResult::Received)); |
There was a problem hiding this comment.
Not exactly sure what this means. This is why I didn't put it in the boring crate at first.
nox
force-pushed
the
shutdown
branch
2 times, most recently
from
857b858
to
b46582e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.