Explicit run mode and --target for CI tests
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hacking the mode detection by looking at the OS and target, just add an explicit variable to control what to do with tests.
When we're testing a target, Cargo needs to be instructed to compile for that target, not for the host environment it's running in. Otherwise, all these "arm-android" tests are just building for "ubuntu-latest" host, which does not really test what it should test. Once you do that, basically everything that is not compiling for the host environment fails to run. Leave some FIXMEs there, for now CI is going to be broken.
I think they belong in the new place, explaining why a particular test-mode is chosed for a target.
Since they no longer explicitly depend on the target OS, just state what we're doing in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demonstration of issue #62.
I'm not really sure what do you want to do with these tests. Right now they are broken and it's not trivial to fix them. Might as well leave them broken as a reminder, or remove them altogether from
ci.ymlto be re-added when they actually work.