-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose set_permute_extensions #247
Conversation
Let's add the SSL variant as well https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#SSL_set_permute_extensions |
@rushilmehra do you mean adding it into impl SslRef {
///...
} ? |
Yeah, that's the one. Is this API incompatible with FIPS? |
There was compilation failure reported by CI in initial commit. CI reported there is no |
Yeah this is because the |
Merged, thanks @mstyura |
Thank you, @rushilmehra, for reviewing and providing valuable feedback. May I kindly ask you to take a look at another one of my PRs? If necessary, I can open a separate issue for further discussion, as the proposed changes are slightly bigger compared to this PR. I initially missed the contributing guidelines, which prefer an issue in addition to a PR when the changes are non-trivial. |
No description provided.