Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose set_permute_extensions #247

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

mstyura
Copy link
Contributor

@mstyura mstyura commented Jul 9, 2024

No description provided.

@rushilmehra
Copy link
Collaborator

Let's add the SSL variant as well https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#SSL_set_permute_extensions

@mstyura
Copy link
Contributor Author

mstyura commented Jul 9, 2024

@rushilmehra do you mean adding it into

impl SslRef {
 ///...
}

?

@rushilmehra
Copy link
Collaborator

Yeah, that's the one. Is this API incompatible with FIPS?

@mstyura
Copy link
Contributor Author

mstyura commented Jul 10, 2024

There was compilation failure reported by CI in initial commit. CI reported there is no ffi::SSL_CTX_set_permute_extensions function. I don't know much about fips, but what I've googled it seems like it could be explained by the absence of certification of the recent enough version of boring ssl.
I see that the SSL_CTX_set_permute_extensions was introduced on 14 June 2021 (https://boringssl-review.googlesource.com/c/boringssl/+/48045), while according to documentation the most recent certification was done 29 April 2021 (https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/FIPS.md)

@rushilmehra
Copy link
Collaborator

Yeah this is because the fips feature builds with a separate version of boringssl: https://github.com/google/boringssl/tree/853ca1ea1168dff08011e5d42d94609cc0ca2e27 which doesn't know about these APIs. I suppose gating it to non-fips is fine, but let's leave a comment in both places describing why it's gated to non-fips. Once we upgrade the submoduled fips commit we can remove these gates

@rushilmehra rushilmehra merged commit 3166592 into cloudflare:master Jul 10, 2024
23 checks passed
@rushilmehra
Copy link
Collaborator

Merged, thanks @mstyura

@mstyura
Copy link
Contributor Author

mstyura commented Jul 10, 2024

Thank you, @rushilmehra, for reviewing and providing valuable feedback. May I kindly ask you to take a look at another one of my PRs? If necessary, I can open a separate issue for further discussion, as the proposed changes are slightly bigger compared to this PR. I initially missed the contributing guidelines, which prefer an issue in addition to a PR when the changes are non-trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants