Rework rpk and no-patches features #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
features
branch
3 times, most recently
from
385c046 to
35c099f
Compare
|
@howardjohn Does the removal of feature |
ghedo
approved these changes
Oct 23, 2023
Feature rpk in boring doesn't do anything unless you explicitly use `SslAcceptor::rpk` or `SslContext::rpk_builder`, and neither of these types are directly reachable if the user depends only on tokio-boring or hyper-boring, which means you still need to explicitly depend on the boring crate to use RPK, in which case you can enable the feature there.
Feature no-patches is ever only useful when setting other env variables
BORING_BSSL{,_FIPS}{,_SOURCE}_PATH, and it has no impact on the APIs
provided by any of the boring crates, so we may as well make it an env
variable itself so downstream users have less features to propagate
across their own crate graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
rpkfrom tokio-boring and hyper-boring, and replaces featureno-patcheswith env variableBORING_BSSL{,_FIPS}_ASSUME_PATCHED, see individual commits for rationale.