Improve X509VerifyResult #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulin
approved these changes
Oct 11, 2023
This commit separates X509VerifyResult::OK from the rest of the codes that actually represent errors, using a Result type as usual.
nox
force-pushed
the
nox/verify-result
branch
from
08c333a to
26cf6e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making it a
c_intwrapper with anOKvariant, we make it a type alias forResult<(), X509VerifyError>, whereX509VerifyErroronly represents failures. This is a breaking change.We also write bindings for all the existing verify error codes.