Update RPK patch to latest patchset #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushilmehra
force-pushed
the
rpk-bump
branch
2 times, most recently
from
a010918
to
3fc8e5c
Compare
inikulin
reviewed
Aug 3, 2023
inikulin
reviewed
Aug 3, 2023
inikulin
reviewed
Aug 3, 2023
rushilmehra
force-pushed
the
rpk-bump
branch
3 times, most recently
from
483cf08
to
db520ac
Compare
inikulin
requested changes
Aug 14, 2023
boring/src/ssl/callbacks.rs
Outdated
| al: *mut u8, | ||
| ) -> ffi::ssl_verify_result_t | ||
| where | ||
| F: Fn(&mut SslRef, &mut u8) -> bool + 'static + Sync + Send, |
There was a problem hiding this comment.
Worth making API safer here by making the closure accept a mut ref to https://docs.rs/boring/latest/boring/ssl/struct.SslAlert.html instead of raw u8
rushilmehra
force-pushed
the
rpk-bump
branch
3 times, most recently
from
78a4cee
to
4d46d27
Compare
nox
reviewed
Oct 6, 2023
nox
reviewed
Oct 6, 2023
nox
requested changes
Oct 9, 2023
| key.as_ptr(), | ||
| ptr::null_mut(), | ||
| )) | ||
| .map(|_| ()) | ||
| } | ||
| } | ||
|
|
||
| pub fn configure_default_rpk_custom_verify(&mut self, cert: &[u8]) -> Result<(), ErrorStack> { |
boring/src/ssl/mod.rs
Outdated
| /// [`SSL_CTX_set_custom_verify`]: https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#SSL_CTX_set_custom_verify | ||
| pub fn set_custom_verify<F>(&mut self, mode: SslVerifyMode, verify: F) | ||
| where | ||
| F: Fn(&mut SslRef, &mut u8) -> bool + 'static + Sync + Send, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.