add support for publishSettings #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesBLewis
force-pushed
the
gh-1026-expose-publishSettings
branch
from
f9ba6c4
to
9343381
Compare
JamesBLewis
changed the title
|
rebase needed |
duglin
reviewed
Jun 25, 2024
| ProjectID: projectID, | ||
| TopicID: topicID, | ||
| SubscriptionID: subID, | ||
| PublishSettings: &pubsub.PublishSettings{ |
There was a problem hiding this comment.
How is topic deletion controlled by this setting?
There was a problem hiding this comment.
Hi @duglin my apologies, your confusion is a result of me copying and modifying one of the existing tests. I have corrected the test now.
JamesBLewis
force-pushed
the
gh-1026-expose-publishSettings
branch
from
912a678
to
0fcf1fb
Compare
JamesBLewis
force-pushed
the
gh-1026-expose-publishSettings
branch
from
0fcf1fb
to
ef734d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1026
Update Connection struct to allow for customising PublishSettings the same way ReceiveSettings can be customised.