Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed license on the nuget package #252

Closed
mieliespoor opened this issue Jan 16, 2023 · 2 comments · Fixed by #253
Closed

Embed license on the nuget package #252

mieliespoor opened this issue Jan 16, 2023 · 2 comments · Fixed by #253
Assignees
@jskeet
Labels
enhancement New feature or request

Comments

@mieliespoor
Copy link

The nuspec specification allows for the license to be specified within the nuspec/csproj files to make it easier to determine which license is being used by the package.

Could all the package from this repo add this to help making it easier for consumers?

<license type="expression">Apache-2.0</license>
@jskeet
Copy link
Contributor

jskeet commented Jan 17, 2023 •
edited
Loading

Possibly. I know we don't do that for Google libraries - there's some disadvantage to using the SPDX identifier instead of embedding the license file directly. I'll look into it; it may not be relevant to CNCF libraries.

@jskeet jskeet self-assigned this Jan 17, 2023
@jskeet jskeet added the enhancement New feature or request label Jan 17, 2023
@jskeet
Copy link
Contributor

jskeet commented Jan 24, 2023

Have asked about this. A conservative reading of the license suggests that the license really should be embedded in the package. Unfortunately we can't specify both <PackageLicenseFile> and <PackageLicenseExpression> in the csproj file (or Directory.Build.props in this particular case).

What I might do is embed the licence file as a regular file within the package, so that we are shipping it, but use <PackageLicenseExpression> to make the package licensing more machine-readable. Will try to get to that this week.

jskeet added a commit to jskeet/sdk-csharp that referenced this issue Jan 25, 2023
@jskeet
Use PackageLicenseExpression instead of PackageLicenseFile
7ef8152 
Note that the license file is still embedded in the package (at the root) to conform with the requirement that it's delivered with the software.

Fixes cloudevents#252

Signed-off-by: Jon Skeet <[email protected]>
@jskeet jskeet mentioned this issue Jan 25, 2023
Merged
jskeet added a commit that referenced this issue Mar 6, 2023
@jskeet
Use PackageLicenseExpression instead of PackageLicenseFile
1fe92ab 
Note that the license file is still embedded in the package (at the root) to conform with the requirement that it's delivered with the software.

Fixes #252

Signed-off-by: Jon Skeet <[email protected]>
jskeet added a commit to jskeet/sdk-csharp that referenced this issue Mar 7, 2023
@jskeet
Release 2.6.0
d0f41f1 
Changes since 2.5.1:

- Dependencies: system-level dependencies updated
- The NuGet package now uses PackageLicenseExpression (but still
  includes the licence file as well).
  Fixes ([cloudevents#252](cloudevents#252)).
- Regenerated protobuf schema using the original filename of
  cloudevents.proto instead of ProtoSchema.proto. An additional
  ProtoSchemaReflection class has been added purely for compatibility.
  Fixes ([cloudevents#256](cloudevents#256)).

Signed-off-by: Jon Skeet <[email protected]>
@jskeet jskeet mentioned this issue Mar 7, 2023
Merged
jskeet added a commit that referenced this issue Mar 7, 2023
@jskeet
Release 2.6.0
d028659 
Changes since 2.5.1:

- Dependencies: system-level dependencies updated
- The NuGet package now uses PackageLicenseExpression (but still
  includes the licence file as well).
  Fixes ([#252](#252)).
- Regenerated protobuf schema using the original filename of
  cloudevents.proto instead of ProtoSchema.proto. An additional
  ProtoSchemaReflection class has been added purely for compatibility.
  Fixes ([#256](#256)).

Signed-off-by: Jon Skeet <[email protected]>
ericdotnet added a commit to ericdotnet/CSharp-sdk-dev that referenced this issue May 13, 2024
@ericdotnet
Release 2.6.0
f33f0bb 
Changes since 2.5.1:

- Dependencies: system-level dependencies updated
- The NuGet package now uses PackageLicenseExpression (but still
  includes the licence file as well).
  Fixes ([#252](cloudevents/sdk-csharp#252)).
- Regenerated protobuf schema using the original filename of
  cloudevents.proto instead of ProtoSchema.proto. An additional
  ProtoSchemaReflection class has been added purely for compatibility.
  Fixes ([#256](cloudevents/sdk-csharp#256)).

Signed-off-by: Jon Skeet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use PackageLicenseExpression instead of PackageLicenseFile jskeet/sdk-csharp
2 participants
@jskeet @mieliespoor