-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonEventFormatter throws exception when charset is included #216
Comments
Thanks, I'll have a look tomorrow. |
Yes, it looks like the check you've suggested is the right one - that's what we do everywhere else. |
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Jun 28, 2022
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Jun 29, 2022
Fixes cloudevents#216 Signed-off-by: Jon Skeet <[email protected]>
jskeet
added a commit
that referenced
this issue
Jun 29, 2022
Fixes #216 Signed-off-by: Jon Skeet <[email protected]>
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Jun 29, 2022
Changes since 2.3.0: - Bug fix: ignore the charset when determining the content type for decoding JSON (cloudevents#216) - Bug fix: make the NuGet package deterministic (cloudevents#175) Signed-off-by: Jon Skeet <[email protected]>
Merged
jskeet
added a commit
that referenced
this issue
Jun 29, 2022
Changes since 2.3.0: - Bug fix: ignore the charset when determining the content type for decoding JSON (#216) - Bug fix: make the NuGet package deterministic (#175) Signed-off-by: Jon Skeet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my AspNetCore app, calling
HttpContext.Request.ToCloudEventAsync(new JsonEventFormatter())
fails when thedatacontenttype
property includes the charset. It throws the following exception =>The following is a sample request that was generated by Dapr.
When the charset is removed, the code works fine.
UPDATE
Just digging around the source seems to be coming from here.
I don't know what the spec says about including charsets. Otherwise, maybe we can use this check instead
The text was updated successfully, but these errors were encountered: