Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPSDX-3117: CLI cleanups and enhancements. #9

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

wonderslug
Copy link
Collaborator

This fixes the default config file via Docker (#4)
as well as adds a --debug option for better visibility
and you can set the CDPCTL_VERSION environment variable
to get a specific docker image version

Closing: #4

Signed-off-by: Brian Towles [email protected]

This fixes the default config file via Docker (#4)
as well as adds a --debug option for better visibility
and you can set the CDPCTL_VERSION environment variable
to get a specific docker image version

Signed-off-by: Brian Towles <[email protected]>
@wonderslug wonderslug added the bug Something isn't working label Aug 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #9 (e7838b8) into dev (96e6f71) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev       #9      +/-   ##
==========================================
- Coverage   70.05%   69.67%   -0.39%     
==========================================
  Files          25       25              
  Lines        1092     1098       +6     
==========================================
  Hits          765      765              
- Misses        327      333       +6     
Flag Coverage Δ
unittests 69.67% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdpctl/cli.py 0.00% <0.00%> (ø)
cdpctl/command/__init__.py 0.00% <ø> (ø)
cdpctl/command/validate.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e6f71...e7838b8. Read the comment docs.

Signed-off-by: Brian Towles <[email protected]>
Copy link
Collaborator

@aakanser aakanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many colors! Looks good to me, left one comment.

@wonderslug wonderslug requested a review from aakanser August 9, 2021 21:10
@wonderslug wonderslug merged commit e6a75ef into dev Aug 9, 2021
@wonderslug wonderslug deleted the CDPSDX-3117 branch August 9, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config file location not being picked up when run via script/docker image
3 participants