Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPSDX-3108 fix subnet natGateway validation #7

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

mahendra-rk
Copy link
Collaborator

Signed-off-by: Mahendra Korepu [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #7 (df46649) into dev (0cfe346) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev       #7   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files          25       25           
  Lines        1092     1092           
=======================================
  Hits          765      765           
  Misses        327      327           
Flag Coverage Δ
unittests 70.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdpctl/validation/infra/validate_aws_subnets.py 90.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfe346...df46649. Read the comment docs.

Copy link
Collaborator

@aakanser aakanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you for the changes!

@wonderslug wonderslug merged commit f02b684 into cloudera-labs:dev Aug 9, 2021
@wonderslug wonderslug added the bug Something isn't working label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants