Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: S3 Bucket must exist in the same region as the environment #36

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

anuragpatro
Copy link
Contributor

Signed-off-by: Anurag Patro [email protected]

Changes to existing code to accommodate validating S3 bucket existing in the same region as the environment.
Thanks

@codecov-commenter
Copy link

Codecov Report

Merging #36 (03d0381) into dev (f5c3c33) will decrease coverage by 0.44%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #36      +/-   ##
==========================================
- Coverage   70.37%   69.93%   -0.45%     
==========================================
  Files          27       27              
  Lines        1249     1254       +5     
==========================================
- Hits          879      877       -2     
- Misses        370      377       +7     
Flag Coverage Δ
unittests 69.93% <64.28%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pctl/validation/infra/validate_aws_s3_locations.py 80.00% <61.53%> (-15.13%) ⬇️
cdpctl/validation/infra/issues.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c3c33...03d0381. Read the comment docs.

@wonderslug wonderslug self-requested a review August 27, 2021 17:34
@wonderslug wonderslug added the enhancement New feature or request label Aug 27, 2021
@wonderslug wonderslug merged commit f5f119e into cloudera-labs:dev Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants