Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCAM-43: Added more links to the Issue Templates #24

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

wonderslug
Copy link
Collaborator

This commits adds more links to the issue_templates.yml files.

Signed-off-by: Brian Towles [email protected]

This commits adds more links to the issue_templates.yml files.

Signed-off-by: Brian Towles <[email protected]>
@wonderslug wonderslug added the skip-changelog Skip entry in changelog label Aug 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #24 (10c31cf) into dev (251c29d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #24   +/-   ##
=======================================
  Coverage   69.86%   69.86%           
=======================================
  Files          27       27           
  Lines        1221     1221           
=======================================
  Hits          853      853           
  Misses        368      368           
Flag Coverage Δ
unittests 69.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251c29d...10c31cf. Read the comment docs.

---
id: AWS_S3_BUCKET_DOES_NOT_EXIST
summary: "S3 bucket {0} does not exist."
docs_link: https://docs.cloudera.com/cdp/latest/requirements-aws/topics/mc-aws-req-s3.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also go without a link for this one as it's self-explanatory. Probably also for forbidden access below. I'm fine either way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thought it it a bit but at least it gives them a link to say ... "oh yeah its it is in the docs"

Copy link
Collaborator

@aakanser aakanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for getting these in

@wonderslug wonderslug merged commit b590222 into dev Aug 23, 2021
@wonderslug wonderslug deleted the CDPCAM-43 branch August 23, 2021 16:30
wonderslug added a commit that referenced this pull request Aug 23, 2021
This commits adds more links to the issue_templates.yml files.

Signed-off-by: Brian Towles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip entry in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants