CDPCAM-48, CDPCAM-43: Custom output and links to docs. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits provides the capability to do different output types (tex and json for now) and provides the different issues encountered with the ability to have links and different formatting. It does this through centralizing the Issue messages into issue_templates.yml files which get loaded at runtime to present the issues to the renderers. The renderers pick the format mechanism defined by the render_type in the issue_templates.yml. The issue ids can be generated into constants using the scripts/update_issue_templates.py script. This will also be run during the pre-commit. Signed-off-by: Brian Towles <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #23 +/- ##
==========================================
- Coverage 70.18% 69.86% -0.33%
==========================================
Files 24 27 +3
Lines 1070 1221 +151
==========================================
+ Hits 751 853 +102
- Misses 319 368 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
aakanser
reviewed
Aug 20, 2021
Signed-off-by: Brian Towles <[email protected]>
aakanser
approved these changes
Aug 20, 2021
mahendra-rk
reviewed
Aug 20, 2021
mahendra-rk
reviewed
Aug 20, 2021
mahendra-rk
reviewed
Aug 20, 2021
Signed-off-by: Brian Towles <[email protected]>
mahendra-rk
reviewed
Aug 20, 2021
mahendra-rk
reviewed
Aug 20, 2021
Signed-off-by: Brian Towles <[email protected]>
wonderslug
added a commit
that referenced
this pull request
Aug 23, 2021
* CDPCAM-48, CDPCAM-43: Custom output and links to docs. This commits provides the capability to do different output types (tex and json for now) and provides the different issues encountered with the ability to have links and different formatting. It does this through centralizing the Issue messages into issue_templates.yml files which get loaded at runtime to present the issues to the renderers. The renderers pick the formatting mechanism defined by the render_type in the issue_templates.yml. The issue ids can be generated into constants using the scripts/update_issue_templates.py script. This will also be run during the pre-commit. Signed-off-by: Brian Towles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits provides the capability to do different output types
(tex and json for now) and provides the different issues encountered
with the ability to have links and different formatting.
It does this through centralizing the Issue messages into
issue_templates.yml files which get loaded at runtime to present the issues
to the renderers. The renderers pick the format mechanism defined by the
render_type in the issue_templates.yml.
The issue ids can be generated into constants using the
scripts/update_issue_templates.py script. This will also be run during
the pre-commit.
Signed-off-by: Brian Towles [email protected]