Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks to verify subnets data type #21

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

mahendra-rk
Copy link
Collaborator

Signed-off-by: Mahendra Korepu [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #21 (ee5db46) into dev (1dba94c) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #21      +/-   ##
==========================================
- Coverage   70.26%   70.18%   -0.08%     
==========================================
  Files          24       24              
  Lines        1066     1070       +4     
==========================================
+ Hits          749      751       +2     
- Misses        317      319       +2     
Flag Coverage Δ
unittests 70.18% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdpctl/validation/infra/validate_aws_subnets.py 87.64% <50.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dba94c...ee5db46. Read the comment docs.

@wonderslug wonderslug added the enhancement New feature or request label Aug 19, 2021
@wonderslug wonderslug merged commit 3463a31 into cloudera-labs:dev Aug 19, 2021
wonderslug pushed a commit that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants