CDPCAM-69: skip CDP CIDR validation if tunnel enabled #16
Conversation
Signed-off-by: Alper Akanser <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #16 +/- ##
==========================================
+ Coverage 70.51% 70.57% +0.05%
==========================================
Files 24 24
Lines 1048 1050 +2
==========================================
+ Hits 739 741 +2
Misses 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -2,4 +2,5 @@ | |||
| markers = | |||
| aws | |||
| infra | |||
| config_value | |||
There was a problem hiding this comment.
Dont think this needs to be here. This is the one for unit tests not validations. It doesnt need to be in the validations.ini either because its registered here:
cdpctl/cdpctl/validation/conftest.py
Lines 206 to 210 in 1d763ba
There was a problem hiding this comment.
We might just be able to remove this whole markers section for now
There was a problem hiding this comment.
Dont think this needs to be here. This is the one for unit tests not validations. It doesnt need to be in the validations.ini either because its registered here:
cdpctl/cdpctl/validation/conftest.py
Lines 206 to 210 in 1d763ba
I added that because I was seeing these when I ran pytest tests:
cdpctl/validation/infra/validate_aws_security_groups.py:138
/workspaces/cdpctl/cdpctl/validation/infra/validate_aws_security_groups.py:138: PytestUnknownMarkWarning: Unknown pytest.mark.config_value - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
@pytest.mark.config_value(path="env:tunnel", value=False)
There was a problem hiding this comment.
Ahh it looks like the unit tests are finding the "tests" in the validation paths. we probably want to limit that.
There was a problem hiding this comment.
We might just be able to remove this whole markers section for now
we get million warnings for markers for pytest tests when we remove the markers section. There is also a pytests.ini btw, not sure why we have both of these files.
There was a problem hiding this comment.
despite this? norecursedirs = cdpctl/validation/*
There was a problem hiding this comment.
Im guessing its erroring out when it finds them from an include actually.
I only think we need the pytest.ini. We can remove the other.
There was a problem hiding this comment.
removed pytests.ini
Signed-off-by: Alper Akanser <[email protected]>
* CDPCAM-69: skip CDP CIDR validation if tunnel enabled Signed-off-by: Alper Akanser <[email protected]>
Signed-off-by: Alper Akanser [email protected]