Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPSDX-3094: fix security groups validation, add tests #10

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Conversation

aakanser
Copy link
Collaborator

Signed-off-by: Alper Akanser [email protected]

Copy link
Collaborator

@mahendra-rk mahendra-rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wonderslug
Copy link
Collaborator

Going to close and open this to trigger the CI

@wonderslug wonderslug closed this Aug 11, 2021
@wonderslug wonderslug reopened this Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #10 (ba2de5e) into dev (c9ed998) will increase coverage by 2.07%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #10      +/-   ##
==========================================
+ Coverage   69.67%   71.75%   +2.07%     
==========================================
  Files          25       25              
  Lines        1098     1108      +10     
==========================================
+ Hits          765      795      +30     
+ Misses        333      313      -20     
Flag Coverage Δ
unittests 71.75% <69.23%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/validation/infra/validate_aws_security_groups.py 88.70% <69.23%> (+18.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ed998...ba2de5e. Read the comment docs.

Signed-off-by: Alper Akanser <[email protected]>
@aakanser aakanser merged commit c65933f into dev Aug 11, 2021
@wonderslug wonderslug added the bug Something isn't working label Aug 11, 2021
@wonderslug wonderslug deleted the CDPSDX-3094 branch August 11, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants