Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for custom tags #31

Merged
merged 3 commits into from
Feb 5, 2024
Merged

feat: Added support for custom tags #31

merged 3 commits into from
Feb 5, 2024

Conversation

Rupalgw
Copy link
Contributor

@Rupalgw Rupalgw commented Feb 1, 2024

what

  • Add custom tags

why

  • Azure Modules only support tags from module.labels.tags, we want that any user to pass their custom tags.

@Rupalgw Rupalgw added the enhancement New feature or request label Feb 1, 2024
@Rupalgw Rupalgw requested review from 13archit and d4kverma February 1, 2024 17:52
@Rupalgw Rupalgw self-assigned this Feb 1, 2024
13archit
13archit reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tf-checks.

@13archit 13archit merged commit 0c6c3f0 into master Feb 5, 2024
23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/module_version branch February 5, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13archit 13archit 13archit left review comments

@d4kverma d4kverma Awaiting requested review from d4kverma

Assignees

@Rupalgw Rupalgw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rupalgw @13archit