Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update #14

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feat/update #14

wants to merge 11 commits into from

Conversation

NotMaharshi
Copy link
Member

@NotMaharshi NotMaharshi commented Sep 17, 2024 •
edited
Loading

what

  • Checked and removed deprecated resources
  • Updated module with latest terraform version
  • Added vnet integration
  • Added appliation insights support
  • Added app container seperate directory ( docker as run time stack )

why

  • There were a lot of changes like app service resource is now divided into two resources linux_web_app and windows_web_app
  • Removed Application insights azure portal error
  • Replaced derecated arguments with new ones

@clouddrove-ci clouddrove-ci self-assigned this Sep 17, 2024
13archit
13archit requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove lints.

versions.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
.github/workflows/tf-checks.yml Outdated Show resolved Hide resolved
_example/complete/linux_web_app/main.tf Outdated
module "resource_group" {
source = "clouddrove/resource-group/azure"
version = "1.0.2"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra space, also check other also and remove.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        









  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @d4kverma
  
    d4kverma



          
            
              
            
          
          d4kverma left review comments

        

        

          

  
      @13archit
  
    13archit



          
            
              
            
          
          13archit requested changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @clouddrove-ci
  
    clouddrove-ci
    

      








      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @NotMaharshi 
        
          @clouddrove-ci 
        
          @13archit 
        
          @d4kverma