Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): Add dns_servers as configuration option #37

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

Moep90
Copy link
Contributor

@Moep90 Moep90 commented May 29, 2024

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting jira issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a Jira issue #123

Copy link
Member

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade the terraform version back to 1.6.6.

anmolnagpal
anmolnagpal previously approved these changes Aug 12, 2024
Copy link
Member

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

versions.tf Show resolved Hide resolved
@clouddrove-ci clouddrove-ci merged commit bae6b46 into clouddrove:master Sep 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants