Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: condition to controll Gateway creation and selector for istio service #52

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix: condition to controll Gateway creation and selector for istio service #52

merged 1 commit into from
Feb 28, 2024

Conversation

h1manshu98
Copy link
Member

what

  • if condition to controll kind: Gateway creation.
  • Update VirtualService gateway field If Gateway is created using helmchart.
  • User defined selector for Gateway to select istio service.
  • Update comments in values.yaml for better clarification.

@h1manshu98 h1manshu98 added the bug Something isn't working label Feb 28, 2024
@h1manshu98 h1manshu98 self-assigned this Feb 28, 2024
@clouddrove-ci clouddrove-ci merged commit f70a8c4 into master Feb 28, 2024
3 checks passed
@clouddrove-ci clouddrove-ci deleted the fix/istio-gateway branch February 28, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clouddrove-ci clouddrove-ci clouddrove-ci approved these changes

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@themaniskshah themaniskshah Awaiting requested review from themaniskshah

@d4kverma d4kverma Awaiting requested review from d4kverma

@nileshgadgi nileshgadgi Awaiting requested review from nileshgadgi

@vaibhav7797 vaibhav7797 Awaiting requested review from vaibhav7797

Assignees

@h1manshu98 h1manshu98

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h1manshu98 @anmolnagpal @clouddrove-ci