fix: condition to control virtualService creation

clouddrove · May 17, 2024 · 313f5a3 · 313f5a3
1 parent 12126c4
commit 313f5a3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/charts/helmchart/config/override-values.yaml b/charts/helmchart/config/override-values.yaml
@@ -57,6 +57,7 @@ service:
 istio:
   enabled: false
   virtualService:
+    enabled: true
     hosts: 
       - test.example.com
       - test-2.example.com
@@ -73,7 +74,6 @@ ingress:
       paths:
         - path: /
           pathType: ImplementationSpecific
-
   tls: []
 
 resource:

diff --git a/charts/helmchart/templates/servicemonitor.yaml b/charts/helmchart/templates/servicemonitor.yaml
@@ -1,5 +1,5 @@
-# This object requires CustomResourceDefinition (crds).
 {{- if .Values.metrics.enabled }}
+# This object requires CustomResourceDefinition (crds).
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:

diff --git a/charts/helmchart/templates/virtualservice.yaml b/charts/helmchart/templates/virtualservice.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.istio.enabled -}}
+{{- if .Values.istio.virtualService.enabled -}}
 apiVersion: networking.istio.io/v1beta1
 kind: VirtualService
 metadata:

diff --git a/charts/helmchart/values.yaml b/charts/helmchart/values.yaml
@@ -73,6 +73,7 @@ istio:
   enabled: false
   # -- virtualService is required when using istio.
   virtualService:
+    enabled: false
     hosts: []
       # - test.example.com
       # - test-2.example.com