Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value from hydrate not used in EloquentController #18

Closed
stfnndrsn opened this issue Aug 30, 2016 · 1 comment
Closed

Return value from hydrate not used in EloquentController #18

stfnndrsn opened this issue Aug 30, 2016 · 1 comment
Labels
bug

Comments

@stfnndrsn
Copy link
Contributor

Is it supposed that the return value isn't used in EloquentController->hydrate()?

See: https://github.com/cloudcreativity/laravel-json-api/blob/master/src/Http/Controllers/EloquentController.php#L233
@lindyhopchris
Copy link
Member

Good spot! The hydrator interface specifies that the object should be returned, so the Eloquent controller should be using the return value.

Thanks for the PR - I'll be able to merge and tag it later this evening (UK time)

@stfnndrsn stfnndrsn mentioned this issue Aug 31, 2016
Merged
lindyhopchris added a commit that referenced this issue Sep 1, 2016
@lindyhopchris
[Bugfix] Use return value from Eloquent controller hydrate method
5befdda 
The hydrator interface defines that the `hydrate` method should be
returning the hydrated object. However, the Eloquent controller
was not using this return value. This commit ensures that they
controller respects the return value from the hydrate method.

Closes issue #18
@batdema batdema mentioned this issue May 18, 2018
Closed
@rekrios rekrios mentioned this issue Jun 7, 2019
Closed
@vlavlad vlavlad mentioned this issue Jun 16, 2019
Closed
@brewers-dev-phil brewers-dev-phil mentioned this issue Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stfnndrsn @lindyhopchris