Use hyphen as default for member names when converting Eloquent attributes #17
Labels
Milestone
Comments
lindyhopchris
added a commit
that referenced
this issue
Sep 1, 2016
The JSON API spec recommends using hyphenated member names. This package now follows that recommendation by default. The Eloquent schema will dasherize model keys, so `foo_bar` will become `foo-bar`. This behaviour can be turned off or overloaded as required. The abstract search will snake case sort parameters if the model uses snake cased attributes. If the model does not use snake case, it will came case the search field instead. The behaviour can be changed by overloaded as required. See issue #17
|
Closing as this is available via Componser on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The JSON API spec recommends that member names use the lower case characters
a-zand the hyphen-as the only allowed characters for member names. This is also the default being adopted by other libraries that implement the spec, e.g. Ember Data.The recommendation is made here:
http://jsonapi.org/recommendations/#naming
Make this the default implementation for this library, by changing
EloquentSchema::keyForAttribute()andAbstractSortedSearch::columnForField()methods.Applications not following this recommendation can keep the old behaviour by overloading these methods.
The text was updated successfully, but these errors were encountered: